Registering providers #227
Description
Specification
We need to discuss and specify how providers are registered.
- Will end users be able to register their own providers?
- Bundled providers need to be registered. (just github for now.)
- How do we handle the clientId for a provider?
Additional context
@joshuakarp @brianbotha you guys should have a chat about how get this working properly in another MR/issue to client-refactoring.
I'm going to add the client id to the src/config.ts you'll need to have that.
The registerProvider is worth a discussion since you need to register a provider before it can be utilised. Question is whether users are meant to register providers?
For our bundled providers, they should all be registered ahead of time.
/**
* Polykey configuration
*/
const config = {
version: '1.0.0', // keep this synchronized with package.json
stateVersion: 1,
providers: {
"github.com": {
clientId: "ca5c4c520da868387c52"
}
}
};
The github.com matches the ProviderId.
@brianbotha please create new issue on GH.