Skip to content

Commit

Permalink
refactor(publish): Punch up loglevel of FYI messages
Browse files Browse the repository at this point in the history
  • Loading branch information
evocateur committed Feb 14, 2019
1 parent 3d18f2f commit ab8cf18
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions commands/publish/__tests__/publish-from-package.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe("publish from-package", () => {

expect(npmPublish).not.toHaveBeenCalled();

const logMessages = loggingOutput("info");
const logMessages = loggingOutput("notice");
expect(logMessages).toContain("No unpublished release found");
});

Expand Down Expand Up @@ -105,7 +105,7 @@ describe("publish from-package", () => {
expect(npmPublish).toHaveBeenCalled();
expect(writePkg.updatedManifest("package-1")).not.toHaveProperty("gitHead");

const logMessages = loggingOutput("info");
const logMessages = loggingOutput("notice");
expect(logMessages).toContain("Unable to verify working tree, proceed at your own risk");
expect(logMessages).toContain(
"Unable to set temporary gitHead property, it will be missing from registry metadata"
Expand Down
6 changes: 3 additions & 3 deletions commands/publish/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ class PublishCommand extends Command {
if (err.failed && err.code === 128 && err.stderr && /not a git repository/.test(err.stderr)) {
// (we tried)
this.logger.silly("EWORKINGTREE", err.message);
this.logger.info("FYI", "Unable to verify working tree, proceed at your own risk");
this.logger.notice("FYI", "Unable to verify working tree, proceed at your own risk");
} else {
// validation errors should be preserved
throw err;
Expand Down Expand Up @@ -506,7 +506,7 @@ class PublishCommand extends Command {
} catch (err) {
// from-package should be _able_ to run without git, but at least we tried
this.logger.silly("EGITHEAD", err.message);
this.logger.info(
this.logger.notice(
"FYI",
"Unable to set temporary gitHead property, it will be missing from registry metadata"
);
Expand All @@ -529,7 +529,7 @@ class PublishCommand extends Command {

return gitCheckout(dirtyManifests, this.execOpts).catch(err => {
this.logger.silly("EGITCHECKOUT", err.message);
this.logger.info("FYI", "Unable to reset working tree changes, this probably isn't a git repo.");
this.logger.notice("FYI", "Unable to reset working tree changes, this probably isn't a git repo.");
});
}

Expand Down

0 comments on commit ab8cf18

Please sign in to comment.