Fix For Rust 180 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abezukor
force-pushed
the
abe/rust_180_fd_fix
branch
from
500c446 to
a546b41
Compare
anubhavm11
approved these changes
Aug 7, 2024
anubhavm11
left a comment
anubhavm11
left a comment
There was a problem hiding this comment.
Works on the app, logic makes sense. Please merge this so that I can start building on master.
abezukor
force-pushed
the
abe/rust_180_fd_fix
branch
from
a546b41 to
481f79d
Compare
Collaborator
Author
PR Approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash in debug builds caused by rust-lang/rust#124210. This was due to the
CBL2CAPChannelclosing the stream file descriptor on close, so we should not also do it again when thetokio::net::UnixStreamis dropped.