Generic Agg will take a candle factory rather than rely on Default #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dam5h
commented
Aug 25, 2025
This adds more flexibility in the types we can aggregate in case we need runtime parameters as part of that logic.
dam5h
force-pushed
the
generic-agg-candle-factory
branch
2 times, most recently
from
1cd11d7 to
1bd2d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more flexibility in the types we can aggregate in case we need runtime parameters as part of that logic.
Changes:
References:
Changes proposed by this PR:
Removed the trait bound for
Defaulton the generic aggregators candle type, instead thenew(...)method will take a zero argument closure.📜 Checklist