Skip to content

Fix GitHub release #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/gh-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,25 @@ on:

jobs:
tagged-release:
name: Tagged release
runs-on: ubuntu-latest

steps:
# Checkout the exact commit tagged on the release.
- name: Checkout repository
uses: actions/checkout@v3
with:
ref: ${{ github.event.release.target_commitish }}

- name: Use NodeJS
uses: actions/setup-node@v3
with:
node-version: 18.x

# If we can't build the release will be canceled.
- name: Build
run: npm run build
- name: Install dependencies and build
run: |
npm install
npm run build

- uses: marvinpinto/action-automatic-releases@latest
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/npm-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
release:
runs-on: ubuntu-latest

steps:
# Checkout the exact commit tagged on the release.
- name: Checkout repository
Expand Down
7 changes: 6 additions & 1 deletion docs/primitives/text.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Add 2d text captions to the scene.
]
}
```
<div class='center' id='graphics-container-1'></div>
<div style='position: relative' class='center' id='graphics-container-1'></div>
<script>
drawGraphics3d(
document.getElementById('graphics-container-1'),
Expand All @@ -44,3 +44,8 @@ Add 2d text captions to the scene.
}
);
</script>

## Notes
- Currently the text use HTML elements with
`position: absolute` so the graphics container must have
`position: relative` if you want to show the text.