Fix bug in matlab/read_MultiCellDS_xml.m #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugs handled: * only one simplified_data tag. don't look for another * MAT.basic_agents --> MAT.cells Other changes: * refactored matlab/read_MultiCellDS_xml.m to use local functions * some renaming of nodes to make more readable * use str2double for efficiency (but really to make matlab not cry) * eliminate unused variables for efficiency (but also for the not crying thing) * == false --> ~ * more efficient setfield implemented (no matlab, no cry) * includes MCDS_constants in MCDS.constants
|
New other change:
|
Duplicate of this I think, but never hurts :) 1f4da4c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive to issue raised in slack re bugs in using the
matlab/read_MultiCellDS_xml.mscript. Perhaps arose due to changes in multicellds output without synching the matlab implementation. see below for detailsBugs handled:
simplified_datatag. don't look for anotherMAT.basic_agents-->MAT.cellsOther changes:
matlab/read_MultiCellDS_xml.mto use local functionsstr2doublefor efficiency (but really to make matlab not cry)== false-->~setfieldimplemented (no matlab, no cry)MCDS_constantsinMCDS.constants