New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CDO and add classes #10

Merged

az-ihsan merged 2 commits into main from update/CDO

Aug 15, 2023

Collaborator

az-ihsan commented Jul 18, 2023

This PR solves #9

removed GrainBoundary class
added BulkDefect, LineDefect, PlaneDefect
Dislocation is now a subclass of LineDefect -> Just to make a bit equal in the organization of the defect.
As I studied again about EMMO, I changed EMMO:Material with EMMO:Solid. The class will be a super-class of CrystallineMaterial


          update CDO and add classes

edf5cd0

az-ihsan requested a review from aazocar

July 18, 2023 08:19


          fix: minor fix of missing prefix in CQs

906d43e

az-ihsan merged commit a50b828 into main

az-ihsan deleted the update/CDO branch

August 15, 2023 09:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet