expr: add scalar function benchmarks #34978
Draft
+5,211
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…funcs Add comprehensive benchmarks using the `bencher` crate covering the full eval path (MirScalarExpr::Literal → datum extraction → function call → result). Multi-input macros (`bench_*_multi!`) evaluate diverse parameter values per iteration for math-sensitive functions (sqrt, trig, log, div, power) to avoid misleading results from "easy" inputs like perfect squares. - bench_binary.rs: ~180 benchmarks (arithmetic, bitwise, comparison, string, pattern matching, encoding, digest, datetime) - bench_unary.rs: ~170 benchmarks (boolean, arithmetic, trig, casts, string, hash, datetime) - bench_variadic.rs: 29 benchmarks (logic, string, JSON, HMAC, datetime) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
antiguru
force-pushed
the
scalar_bench
branch
from
4395b86 to
a5cfe6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
benchercratebench_*_multi!) evaluate diverse parameter values per iteration for math-sensitive functions (sqrt, trig, log, div, power) to avoid misleading results from "easy" inputsKey findings from initial run
RegexpMatch~47 us due to per-call regex compilationTest plan
cargo bench -p mz-expr --bench bench_binary— 191 benchmarks passcargo bench -p mz-expr --bench bench_unary— 213 benchmarks passcargo bench -p mz-expr --bench bench_variadic— 29 benchmarks pass🤖 Generated with Claude Code