CollectionBundles use Rc'ed collections #34939
Open
+117
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering sometimes brings collections into regions, or out of regions where nothing consumes the stream. This causes us to clone the contents even though they'll be dropped immediately, wasting CPU time. This change doesn't address this problem, but mitigates its cost. Cloning an Rc is cheaper than cloning a vector. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Member
Author
|
The PR avoids the problem of cloning the data and replaces it by cloning the reference: Unfortunately, it adds many shared/unshared operators: 
This one shared for putting data into a collection bundle, and one unshared for taking it out, pretty much two (data, error) for each collection imported into an LIR node. I wonder if the cost of this is too high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering sometimes brings collections into regions, or out of regions where nothing consumes the stream. This causes us to clone the contents even though they'll be dropped immediately, wasting CPU time. This change doesn't address this problem, but mitigates its cost. Cloning an Rc is cheaper than cloning a vector.