adapter/caught-up: ignore beyond_all_hope collections #33803
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
commented
Oct 8, 2025
| "with_0dt_caught_up_check_cutoff", | ||
| Duration::from_secs(10 * 60), // 10 minutes | ||
| "During a 0dt deployment, if a cluster has only 'problematic' (crash-looping) replicas _and_ any collection that is behind by more than this cutoff, the cluster will be ignored in caught-up checks.", | ||
| Duration::from_secs(2 * 60 * 60), // 2 hours |
There was a problem hiding this comment.
Changed this back to the old default, since cutting over too soon is worse than cutting over too late. A value between the two might work as well, but not sure how to choose one.
This commit restores the previous behavior where the caught-up checker ignores collections whose live frontier is more than two hours behind, to ensure we don't get stuck on broken sources or compute collections that for some reason cannot make progress without ooming their cluster.
teskje
force-pushed
the
caught-up-exclude-beyond_all_hope
branch
from
77c6421 to
7b72d8f
Compare
|
Oh, I just remembered that the doc comments of
But it's also ok if this is considered out of scope for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the previous behavior where the caught-up checker ignores collections whose live frontier is more than two hours behind, to ensure we don't get stuck on broken sources or compute collections that for some reason cannot make progress without ooming their cluster.
Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/9721
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.