Skip to content

compute,storage: downgrade config update logs #33760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compute,storage: downgrade config update logs #33760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/compute/src/compute_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ use timely::progress::frontier::Antichain;
use timely::scheduling::Scheduler;
use timely::worker::Worker as TimelyWorker;
use tokio::sync::{oneshot, watch};
use tracing::{Level, debug, error, info, span, warn};
use tracing::{Level, debug, error, info, span, trace, warn};
use uuid::Uuid;

use crate::arrangement::manager::{TraceBundle, TraceManager};
Expand Down Expand Up @@ -443,7 +443,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> {
}

fn handle_update_configuration(&mut self, params: ComputeParameters) {
info!("Applying configuration update: {params:?}");
debug!("Applying configuration update: {params:?}");

let ComputeParameters {
workload_class,
Expand Down Expand Up @@ -876,9 +876,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> {
let peek_persist_stash_available =
self.compute_state.peek_stash_persist_location.is_some();
if !peek_persist_stash_available && enabled {
tracing::error!(
"missing peek_stash_persist_location but peek stash is enabled"
);
error!("missing peek_stash_persist_location but peek stash is enabled");
}
enabled && peek_persist_stash_available
};
Expand Down Expand Up @@ -936,7 +934,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> {
.metrics
.stashed_peek_seconds
.observe(duration.as_secs_f64());
tracing::trace!(?stashing_peek.peek, ?duration, "finished stashing peek response in persist");
trace!(?stashing_peek.peek, ?duration, "finished stashing peek response in persist");

Some(response)
} else {
Expand Down Expand Up @@ -1336,7 +1334,7 @@ impl PersistPeek {
}

let count: usize = d.try_into().map_err(|_| {
tracing::error!(
error!(
shard = %metadata.data_shard, diff = d, ?row,
"persist peek encountered negative multiplicities",
);
Expand Down Expand Up @@ -1451,7 +1449,7 @@ impl IndexPeek {
});
if copies.is_negative() {
let error = cursor.key(&storage);
tracing::error!(
error!(
target = %self.peek.target.id(), diff = %copies, %error,
"index peek encountered negative multiplicities in error trace",
);
Expand Down
10 changes: 5 additions & 5 deletions src/storage/src/storage_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ use timely::progress::frontier::Antichain;
use timely::worker::Worker as TimelyWorker;
use tokio::sync::{mpsc, watch};
use tokio::time::Instant;
use tracing::{info, warn};
use tracing::{debug, info, warn};
use uuid::Uuid;

use crate::internal_control::{
Expand Down Expand Up @@ -737,7 +737,7 @@ impl<'w, A: Allocate> Worker<'w, A> {
// management being a bit of a mess. we should clean this up and remove weird if
// statements like this.
if resume_uppers.values().all(|frontier| frontier.is_empty()) || as_of.is_empty() {
tracing::info!(
info!(
?resume_uppers,
?as_of,
"worker {}/{} skipping building ingestion dataflow \
Expand Down Expand Up @@ -985,7 +985,7 @@ impl<'w, A: Allocate> Worker<'w, A> {
}

for ingestion_id in to_remove {
tracing::info!(?ingestion_id, "removing oneshot ingestion");
info!(?ingestion_id, "removing oneshot ingestion");
self.storage_state.oneshot_ingestions.remove(&ingestion_id);
}
}
Expand Down Expand Up @@ -1302,7 +1302,7 @@ impl StorageState {
}
StorageCommand::UpdateConfiguration(params) => {
// These can be done from all workers safely.
tracing::info!("Applying configuration update: {params:?}");
debug!("Applying configuration update: {params:?}");

// We serialize the dyncfg updates in StorageParameters, but configure
// persist separately.
Expand Down Expand Up @@ -1452,6 +1452,6 @@ impl StorageState {
/// Drop the identified oneshot ingestion from the storage state.
fn drop_oneshot_ingestion(&mut self, ingestion_id: uuid::Uuid) {
let prev = self.oneshot_ingestions.remove(&ingestion_id);
tracing::info!(%ingestion_id, existed = %prev.is_some(), "dropping oneshot ingestion");
info!(%ingestion_id, existed = %prev.is_some(), "dropping oneshot ingestion");
}
}