Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explainability] change EXPLAIN ... AS TEXT in tests to EXPLAIN ... AS VERBOSE TEXT ... #31560

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
actually wire up explain_verbose_text
  • Loading branch information
mgree committed Feb 19, 2025
commit 9484eea8f564527fa00cfd1eb503014d38c1e7b6
7 changes: 7 additions & 0 deletions src/adapter/src/explain/fast_path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ impl<'a> Explain<'a> for Explainable<'a, FastPathPlan> {
self.as_explain_multi_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_multi_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Text, ExplainError> {
self.as_explain_multi_plan(context)
}
Expand Down
7 changes: 7 additions & 0 deletions src/adapter/src/explain/hir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ impl<'a> Explain<'a> for Explainable<'a, HirRelationExpr> {
self.0.explain_text(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.0.explain_verbose_text(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Json, ExplainError> {
self.0.explain_json(context)
}
Expand Down
7 changes: 7 additions & 0 deletions src/adapter/src/explain/lir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ impl<'a> Explain<'a> for Explainable<'a, DataflowDescription<Plan>> {
self.0.explain_text(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.0.explain_verbose_text(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Json, ExplainError> {
self.0.explain_json(context)
}
Expand Down
14 changes: 14 additions & 0 deletions src/adapter/src/explain/mir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ impl<'a> Explain<'a> for Explainable<'a, MirRelationExpr> {
self.as_explain_single_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_single_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Json, ExplainError> {
self.as_explain_single_plan(context)
}
Expand Down Expand Up @@ -88,6 +95,13 @@ impl<'a> Explain<'a> for Explainable<'a, DataflowDescription<OptimizedMirRelatio
self.as_explain_multi_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_multi_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Text, ExplainError> {
self.as_explain_multi_plan(context)
}
Expand Down
14 changes: 14 additions & 0 deletions src/compute-types/src/explain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ impl<'a> Explain<'a> for DataflowDescription<Plan> {
self.as_explain_multi_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_multi_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Text, ExplainError> {
self.as_explain_multi_plan(context)
}
Expand Down Expand Up @@ -100,6 +107,13 @@ impl<'a> Explain<'a> for DataflowDescription<OptimizedMirRelationExpr> {
self.as_explain_multi_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_multi_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Text, ExplainError> {
self.as_explain_multi_plan(context)
}
Expand Down
7 changes: 7 additions & 0 deletions src/expr/src/explain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,13 @@ impl<'a> Explain<'a> for MirRelationExpr {
self.as_explain_single_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_single_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Json, ExplainError> {
self.as_explain_single_plan(context)
}
Expand Down
7 changes: 7 additions & 0 deletions src/sql/src/plan/explain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ impl<'a> Explain<'a> for HirRelationExpr {
self.as_explain_single_plan(context)
}

fn explain_verbose_text(
&'a mut self,
context: &'a Self::Context,
) -> Result<Self::VerboseText, ExplainError> {
self.as_explain_single_plan(context)
}

fn explain_json(&'a mut self, context: &'a Self::Context) -> Result<Self::Json, ExplainError> {
self.as_explain_single_plan(context)
}
Expand Down