[sinks] Set with_snapshot=false even during history reduction #31490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #31152, we added an optimization for
with_snapshot
that kicks in when environmentd restarts, such as during a deploy. However, if only clusterd restarts, we will use the sink definition cached in thehistory
implementation... and if the first run of the sink needed the snapshot, then we'll fetch the snapshot after a restart too.This PR also applies the optimization in the history, so the snapshot can be skipped when even the first run of a sink is restarted. I feel less confident in this change, since the "chain of reasoning" that implies it is safe is a bit more complex. But it may be worthwhile to avoid the operational surprise.
Happy for feedback on this point however!
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.