Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blns: Remove duplicate strings #24078

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

def-
Copy link
Contributor

@def- def- commented Dec 21, 2023

Since our tests depend on them being unique, thanks to ParkMyCar for noticing: #24019 (comment)

Via sort misc/python/materialize/blns.json | uniq -c | grep -Ev " *1 "

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

Since our tests depend on them being unique, thanks to ParkMyCar for
noticing: MaterializeInc#24019 (comment)
@def- def- merged commit dbff751 into MaterializeInc:main Dec 21, 2023
67 checks passed
@def- def- deleted the pr-blns-duplicate branch December 21, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants