Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-test: Reenable test_emit_tracing_notice #24038

Merged
merged 1 commit into from
Dec 20, 2023
Merged

cargo-test: Reenable test_emit_tracing_notice #24038

merged 1 commit into from
Dec 20, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Dec 19, 2023

Fixes: MaterializeInc/database-issues#7034

Seems to not fail flakily anymore.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- requested a review from a team as a code owner December 19, 2023 23:57
@def- def- requested a review from jkosh44 December 19, 2023 23:57
@def- def- merged commit 7cc513e into MaterializeInc:main Dec 20, 2023
63 checks passed
@def- def- deleted the pr-23396 branch December 20, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrainer-materialize nrainer-materialize nrainer-materialize approved these changes

@philip-stoev philip-stoev philip-stoev approved these changes

@jkosh44 jkosh44 Awaiting requested review from jkosh44 jkosh44 is a code owner automatically assigned from MaterializeInc/adapter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@def- @philip-stoev @nrainer-materialize