-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: handle accepted regressions in release builds #23984
Merged
nrainer-materialize
merged 8 commits into
MaterializeInc:main
from
nrainer-materialize:tests/handle-accepted-regressions-in-release-builds
Dec 20, 2023
Merged
tests: handle accepted regressions in release builds #23984
nrainer-materialize
merged 8 commits into
MaterializeInc:main
from
nrainer-materialize:tests/handle-accepted-regressions-in-release-builds
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Dec 18, 2023
nrainer-materialize
force-pushed
the
tests/handle-accepted-regressions-in-release-builds
branch
3 times, most recently
from
December 19, 2023 10:22
110ad9d
to
acf11ca
Compare
nrainer-materialize
force-pushed
the
tests/handle-accepted-regressions-in-release-builds
branch
from
December 20, 2023 09:02
acf11ca
to
e6ccb7e
Compare
Nightly comparing
✅ Feature benchmark prints:
|
nrainer-materialize
force-pushed
the
tests/handle-accepted-regressions-in-release-builds
branch
from
December 20, 2023 09:12
e6ccb7e
to
2590803
Compare
nrainer-materialize
force-pushed
the
tests/handle-accepted-regressions-in-release-builds
branch
from
December 20, 2023 09:16
2590803
to
4cbfcd7
Compare
nrainer-materialize
deleted the
tests/handle-accepted-regressions-in-release-builds
branch
December 20, 2023 10:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A known performance and scalability regression was introduced in v0.80.0. While regular nightly builds did not fail because because the regressions were marked as accepted, this was not the case for the release build.
This PR considers known regressions when running nightly builds for releases, which are based on versions.
Commits
cfce28b docker: add utility methods to classify image tag
6ceb50c tests: identify accepted regressions between two versions
89cafdb scalability framework: refactorings: extract methods
244a70a scalability framework: store resolved target of endpoints
bf2fa67 scalability framework: collect endpoints with regressions
1d8b4c5 scalability framework: print assessment, do not fail on justified regressions
c2f222c feature benchmark: refactoring: variable usages
4cbfcd7 feature benchmark: print assessment, do not fail on justified regressions
Status
Draft, need to go over the code myself again.✅Please pay special attention to c2f222c, which seems risky.
Nightlies