Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kube to 0.87.1 and k8s-openapi to 0.20.0 #23333

Merged

Conversation

alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented Nov 20, 2023

Bumps kube to 0.87.1 and k8s-openapi to 0.20.0.
To avoid duplicate dependencies, it also bumps serde_with and serde_with_macros to 2.3.3, and mysql_async to 0.33.0.
Also bumps our k8s-openapi feature to v1_26, since we recently upgraded our kubernetes clusters to 1.26.

Motivation

  • This PR fixes a previously unreported bug.
    We hit a hang in one of our controllers a couple weeks ago, and it looks like that might have been fixed in kube 0.87.1.
    Also, it's generally good to keep deps updated.

Tips for reviewer

There is a new optional field in the ResourceRequirements struct in Kubernetes 1.26, which we aren't using. That is the only non-Cargo change in this PR.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
    • This is a pre-requisite to bumping it in the cloud repo. I can't open a PR there until this is in.
  • This PR includes the following user-facing behavior changes:
    • no user-facing behavior changes.

@alex-hunt-materialize
Copy link
Contributor Author

I'm hitting duplicate dependency issues, which I think I have mostly figured out. We have only one more dupe, which is fixed on my fork, but needs MaterializeInc/rust-server-sdk#5 merged before I can point at the materialize fork for this PR.

also bumps a few other deps to satisfy the no duplicates rules.
@alex-hunt-materialize alex-hunt-materialize merged commit b7eb487 into MaterializeInc:main Nov 21, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants