sql-pretty: add pretty printing crate #22251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
force-pushed
the
pretty
branch
3 times, most recently
from
3c18303
to
373a694
Compare
ParkMyCar
approved these changes
Oct 10, 2023
src/sql-pretty/src/lib.rs
Outdated
| .group() | ||
| } | ||
|
|
||
| // |
There was a problem hiding this comment.
This was an intended comment to separate util functions from doc functions. I've made those separate files instead.
maddyblue
force-pushed
the
pretty
branch
4 times, most recently
from
37a33fe
to
577688b
Compare
This is copied from github.com/mjibson/mzfmt but now integrated directly into our repo. Refactor the parser tests to reuse the datadriven statements for verification here. That will prevent future syntax changes from lagging behind in their pretty implementation. Integration into `SHOW` and other commands in future commits.
|
I've also rejiggered the cargo.toml dependencies so parser didn't get any new dependencies in its production use path, but now has a test feature that is only used by test builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is copied from github.com/mjibson/mzfmt but now integrated directly into our repo. Refactor the parser tests to reuse the datadriven statements for verification here. That will prevent future syntax changes from lagging behind in their pretty implementation.
Integration into
SHOWand other commands in future commits.Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.