Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stash: Remove old versions #22201

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ParkMyCar
Copy link
Member

@ParkMyCar ParkMyCar commented Oct 5, 2023

This PR removes versions of the Stash that were introduced in v0.67 or older, the current production release is v0.71.

Motivation

Reduces build and test times of the mz_stash crate.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • N/a

@ParkMyCar ParkMyCar marked this pull request as ready for review October 6, 2023 20:55
@ParkMyCar ParkMyCar requested a review from a team as a code owner October 6, 2023 20:55
Copy link
Contributor

@maddyblue maddyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I thought that removing old versions required changing the initial stash population too?

@ParkMyCar
Copy link
Member Author

required changing the initial stash population too?

Do you mean the initialization flow? If so, initializing a new Stash/Catalog intentionally uses the latest proto objects, and does not use any old version, which makes a delete like this safe.

Copy link
Contributor

@maddyblue maddyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I did not realize that stash opening does either init or upgrade. I would have pushed we do this PR much earlier if I had known that since there's no real choices to be made. Neat!

@ParkMyCar ParkMyCar merged commit adf410d into MaterializeInc:main Oct 10, 2023
62 checks passed
@ParkMyCar ParkMyCar deleted the stash/clear-old-versions branch October 16, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants