Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balancer: initial working balancer process #22125

Merged
merged 1 commit into from
Oct 5, 2023
Merged

balancer: initial working balancer process #22125

merged 1 commit into from
Oct 5, 2023

Conversation

maddyblue
Copy link
Contributor

This is not yet ready for production. The code here should be enough to allow cloud to start testing.

Working:

  • pgwire with no tls
  • pgwire with tls
  • static resolver (no frontegg) for local dev
  • frontegg resolver

Not implemented:

  • https
  • metrics
  • memory constraints

See MaterializeInc/database-issues#6555

Motivation

  • This PR adds a known-desirable feature.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • n/a

@maddyblue maddyblue requested review from a team and benesch as code owners October 2, 2023 21:57
@maddyblue maddyblue force-pushed the balancer-mvp branch 3 times, most recently from 705a47d to d7739d8 Compare October 3, 2023 04:43
@benesch benesch removed their request for review October 3, 2023 06:48
ParkMyCar
ParkMyCar approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its happening

src/balancer/src/codec.rs Outdated Show resolved Hide resolved
src/balancer/src/codec.rs Outdated Show resolved Hide resolved
src/balancer/src/lib.rs Outdated Show resolved Hide resolved
src/balancer/src/lib.rs Outdated Show resolved Hide resolved
src/balancer/src/lib.rs Outdated Show resolved Hide resolved
@maddyblue
balancerd: initial working balancer process
af6c4cb 
This is not yet ready for production. The code here should be enough to
allow cloud to start testing.

Working:

- pgwire with no tls
- pgwire with tls
- static resolver (no frontegg) for local dev
- frontegg resolver

Not implemented:

- https
- metrics
- memory constraints

See #21843
@maddyblue maddyblue merged commit 67e0544 into MaterializeInc:main Oct 5, 2023
62 of 63 checks passed
@maddyblue maddyblue deleted the balancer-mvp branch October 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkMyCar ParkMyCar ParkMyCar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddyblue @ParkMyCar