Add metrics for optimization notices #21868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
added
A-optimization
6 tasks
aalexandrov
reviewed
Sep 21, 2023
| session.add_notice(AdapterNotice::DroppedInUseIndex(dropped_in_use_index)); | ||
| self.metrics | ||
| .optimization_notices | ||
| .with_label_values(&["DroppedInUseIndex"]) |
Contributor
There was a problem hiding this comment.
I'm not sure if adding a value should be preferred over adding a separate metric per notice type. cc @teskje what would be better for minimizing the number of metrics?
Contributor
There was a problem hiding this comment.
the # of time series will be the same either way (the name && labels together are uniquely identifying). what's here looks great
ggevay
force-pushed
the
notice-metrics
branch
from
e9c379b to
a67eb34
Compare
ggevay
force-pushed
the
notice-metrics
branch
from
a67eb34 to
168fa78
Compare
Contributor
Author
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics for the notices that we have about indexes:
This will make it easier to prioritize follow-up work, e.g., adding other similar notices, and surfacing these notices properly in built-in tables and the Web Console.
I also sneaked in a notice message change discussed here.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.