DataflowError decoding fallback to the legacy format #21865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
changed the title
teskje
force-pushed
the
dataflowerror-fix
branch
from
b57dcde
to
c34474d
Compare
petrosagg
approved these changes
Sep 21, 2023
teskje
force-pushed
the
dataflowerror-fix
branch
from
c34474d
to
23f0e14
Compare
In MaterializeInc#21510 we introduced a change to the `DataflowError` protos that wasn't backward compatible. This made Mz panic on some persisted `DataflowError`s because it was unable to decode them anymore. This commit fixes the `DataflowError` (and `SourceData`) decoding by falling back to `*Legacy` proto versions in case decoding with the new versions fails.
teskje
force-pushed
the
dataflowerror-fix
branch
from
23f0e14
to
1378359
Compare
|
Sentry issue: DATABASE-BACKEND-2YB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21510 we introduced a change to the
DataflowErrorprotos that wasn't backward compatible. This made Mz panic on some persistedDataflowErrors because it was unable to decode them anymore.This PR fixes the
DataflowError(andSourceData) decoding by falling back to*Legacyproto versions in case decoding with the new versions fails.Motivation
Clusters running Mz version 0.69 are not able to read
DataflowErrors persisted by earlier versions. Instead they panic with "decoding failed" errors.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.