Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist: hook up tokio TaskMonitor to read lease heartbeat task #21857

Merged
merged 4 commits into from
Sep 21, 2023
Merged

persist: hook up tokio TaskMonitor to read lease heartbeat task #21857

merged 4 commits into from
Sep 21, 2023

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Sep 20, 2023

For additional visibility into how tasks and tokio runtimes are behaving in practice.

Motivation

  • This PR adds a feature that has not yet been specified.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@danhhz
persist: hook up tokio TaskMonitor to read lease heartbeat task
d0d6868 
For additional visibility into how tasks and tokio runtimes are behaving
in practice.
danhhz
danhhz commented Sep 21, 2023
View reviewed changes
src/persist-client/src/internal/metrics.rs Outdated Show resolved Hide resolved
src/persist-client/src/internal/metrics.rs Outdated Show resolved Hide resolved
@bkirwi
Add a task-metrics metrics collector
d44a009 
This avoids re-fetching all metrics for every gauge, at the cost of some
extra hoops.
danhhz
danhhz commented Sep 21, 2023
View reviewed changes
Copy link
Contributor Author

@danhhz danhhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/persist-client/src/internal/metrics.rs Outdated Show resolved Hide resolved
@danhhz danhhz marked this pull request as ready for review September 21, 2023 19:57
@danhhz danhhz requested review from benesch and a team as code owners September 21, 2023 19:57
@bkirwi
Copy link
Contributor

bkirwi commented Sep 21, 2023

The commits that aren't mine LGTM!

@danhhz danhhz enabled auto-merge (squash) September 21, 2023 20:08
@bkirwi
Copy link
Contributor

bkirwi commented Sep 21, 2023

Fast SQL test failures appear to be known issue on main; retrying.

guswynn
guswynn approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@guswynn guswynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@danhhz danhhz enabled auto-merge (squash) September 21, 2023 21:02
@danhhz danhhz merged commit f064bf5 into MaterializeInc:main Sep 21, 2023
@danhhz danhhz deleted the persist_task_metrics branch September 21, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guswynn guswynn guswynn approved these changes

@bkirwi bkirwi Awaiting requested review from bkirwi

@benesch benesch Awaiting requested review from benesch benesch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danhhz @bkirwi @guswynn