mzcompose: Retry all docker compose up failures twice
#21830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Sep 20, 2023
philip-stoev
force-pushed
the
mzcompose_retry_docker
branch
from
570a4e6
to
946ac04
Compare
In order to paper over transient DockerHub and container startup issues, retry `docker compose up` up to two times in case of an error.
philip-stoev
force-pushed
the
mzcompose_retry_docker
branch
from
946ac04
to
bd4da20
Compare
def-
added a commit
to def-/materialize
that referenced
this pull request
Sep 25, 2023
Follow-up to MaterializeInc#21830 In command line usage of mzcompose docker gateway timeouts can still happen, see for example https://buildkite.com/materialize/tests/builds/64336#018ac073-cc71-4247-bcff-b11dfe199f14
def-
added a commit
to def-/materialize
that referenced
this pull request
Sep 25, 2023
Follow-up to MaterializeInc#21830 In command line usage of mzcompose docker gateway timeouts can still happen, see for example https://buildkite.com/materialize/tests/builds/64336#018ac073-cc71-4247-bcff-b11dfe199f14
def-
added a commit
to def-/materialize
that referenced
this pull request
Sep 25, 2023
Follow-up to MaterializeInc#21830 In command line usage of mzcompose docker gateway timeouts can still happen, see for example https://buildkite.com/materialize/tests/builds/64336#018ac073-cc71-4247-bcff-b11dfe199f14
def-
added a commit
to def-/materialize
that referenced
this pull request
Sep 26, 2023
Follow-up to MaterializeInc#21830 In command line usage of mzcompose docker gateway timeouts can still happen, see for example https://buildkite.com/materialize/tests/builds/64336#018ac073-cc71-4247-bcff-b11dfe199f14
def-
added a commit
to def-/materialize
that referenced
this pull request
Sep 29, 2023
Follow-up to MaterializeInc#21830 In command line usage of mzcompose docker gateway timeouts can still happen, see for example https://buildkite.com/materialize/tests/builds/64336#018ac073-cc71-4247-bcff-b11dfe199f14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to paper over transient DockerHub and container startup issues, retry
docker compose upup to two times in case of an error.Motivation
We are experiencing transient failures in DockerHub and when starting certain third-party dependencies.
Tips for reviewer
Since we are not capturing stdout/stderr, it is not possible to have a list of more specific retriable errors. We can not capture stdout/stderr easily because the docker progress animations are also sent to stderr, so they will no longer be displayed without additional hacking.