Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter internal users from statement logging #21823

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

umanwizard
Copy link
Contributor

@umanwizard umanwizard commented Sep 19, 2023

Motivation

  • This PR adds a known-desirable feature.

Internal users should be filtered out from statement logging
Fixes https://github.com/MaterializeInc/console/issues/504

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • Filter statements executed by internal users from statement logging

@umanwizard umanwizard enabled auto-merge (squash) September 19, 2023 20:15
@umanwizard umanwizard merged commit 0b1e50c into MaterializeInc:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants