[persist] Dynamic lease timeouts #21822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhhz
approved these changes
Sep 19, 2023
bkirwi
force-pushed
the
dynamic-lease
branch
2 times, most recently
from
6f415eb
to
004d70c
Compare
|
@bkirwi I verified locally that the cfg is hooked up to |
bkirwi
force-pushed
the
dynamic-lease
branch
from
004d70c
to
67df2e7
Compare
danhhz
approved these changes
Sep 19, 2023
|
I've also checked alter-system-set and verified that the new thread name is visible to lldb and formatted nicely. |
petrosagg
pushed a commit
to petrosagg/materialize
that referenced
this pull request
Sep 21, 2023
This is a long-time known-useful knob which has recently become more urgent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a long-time known-useful knob which has recently become more urgent.
Closes MaterializeInc/database-issues#6546
Tips for reviewer
I have not yet tested that all the wiring is set up correctly; will comment when that's done.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.