Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: merge Controller with StorageControllerState #21810

Merged
merged 1 commit into from
Sep 19, 2023
Merged

storage: merge Controller with StorageControllerState #21810

merged 1 commit into from
Sep 19, 2023

Conversation

petrosagg
Copy link
Contributor

@petrosagg petrosagg commented Sep 19, 2023 •
edited
Loading

Motivation

I can't remember how or why the controller evolved to have its state in a separate struct but it doesn't make a lot of sense so I merged them.

The PR is purely code movement so no need to look at the diff too closely

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@petrosagg
storage: merge Controller with StorageControllerState
d092637 
I can't remember how or why the controller evolved to have its state in
a separate struct but it doesn't make a lot of sense so I merged them.

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg requested a review from a team September 19, 2023 13:16
petrosagg
petrosagg commented Sep 19, 2023
View reviewed changes
src/storage-controller/src/lib.rs
/// The build information for this process.
build_info: &'static BuildInfo,
/// The state for the storage controller.
/// TODO(benesch): why is this a separate struct?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benesch fixed

benesch
benesch approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@petrosagg petrosagg merged commit 49f50b7 into MaterializeInc:main Sep 19, 2023
@petrosagg petrosagg deleted the controller-no-state-struct branch September 19, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrosagg @benesch