Skip to content

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Sep 18, 2023

And then MZFROM it in maelstrom-persist. This way we don't have to re-install the apt things or maelstrom every time we get a CI builder with a cold cache.

Motivation

  • This PR refactors existing code.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

And then MZFROM it in maelstrom-persist. This way we don't have to
re-install the apt things or maelstrom every time we get a CI builder
with a cold cache.
@danhhz danhhz requested a review from benesch September 18, 2023 20:40
@danhhz danhhz marked this pull request as ready for review September 18, 2023 20:40
@danhhz danhhz requested a review from a team as a code owner September 18, 2023 20:40
@bkirwi
Copy link
Contributor

bkirwi commented Sep 18, 2023

On board in principle... I'll check back in once the build is green!

@danhhz
Copy link
Contributor Author

danhhz commented Sep 18, 2023

The build failure is that @benesch has to create the new image in dockerhub :D

Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good with Docker Hub now.

@danhhz
Copy link
Contributor Author

danhhz commented Sep 19, 2023

TFTRs!

@danhhz danhhz merged commit f242208 into MaterializeInc:main Sep 19, 2023
@danhhz danhhz deleted the persist_cli_docker branch September 19, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants