persist: fix flaky apply_unbatched_cmd_truncate test #21804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen a recent spat of 14 vs 14 failures here. The point isn't the specific bound, just that there is one (plus, "max" sounds inclusive anyway) so change the < to <=. Closes #20092
bkirwi
approved these changes
Sep 20, 2023
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a recent spat of 14 vs 14 failures here. The point isn't the specific bound, just that there is one (plus, "max" sounds inclusive anyway) so change the < to <=.
Closes MaterializeInc/database-issues#6007
Motivation
Tips for reviewer
I didn't look too hard at the mechanics of what is happening in the flake cases, but feels fine to do this to stop the bleeding.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.