-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the canary environment
mzcompose workflow to run against the Materialize Production Sandbox
#21799
Merged
philip-stoev
merged 7 commits into
MaterializeInc:main
from
philip-stoev:canary-environment-shared-cloud
Sep 19, 2023
Merged
Allow the canary environment
mzcompose workflow to run against the Materialize Production Sandbox
#21799
philip-stoev
merged 7 commits into
MaterializeInc:main
from
philip-stoev:canary-environment-shared-cloud
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error is encountered, testdrive prints the entire line where the error happened. Certain lines can contain passwords which should not be printed as this will cause them to end up in the Buildkite log and artifacts.
philip-stoev
requested review from
def- and
nrainer-materialize
and removed request for
a team
September 18, 2023 12:36
philip-stoev
changed the title
Allow the
Allow the Sep 18, 2023
canary environment
mzcompose workflow to run against the shared sandboxcanary environment
mzcompose workflow to run against the Materialize Production Sandbox
Environment variables are used to pass connection secrets to dbt.
philip-stoev
force-pushed
the
canary-environment-shared-cloud
branch
from
September 18, 2023 12:45
c479b3e
to
7177486
Compare
def-
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, some minor suggestions for the README
philip-stoev
force-pushed
the
canary-environment-shared-cloud
branch
from
September 19, 2023 09:46
7177486
to
b3a6d1a
Compare
def-
approved these changes
Sep 19, 2023
Adjust mzcompose so that it connects to the production cloud. All required connection information is passed as environment variables.
philip-stoev
force-pushed
the
canary-environment-shared-cloud
branch
from
September 19, 2023 10:57
b3a6d1a
to
dd7cb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our canary environments that were used to determine if a release is good enough to go were largely empty/idle and were therefore not a good canary for anything.
With this mzcompose workflow, one can create a complete set of sources/generators/materialized views and then validate that they are running properly and have not stalled for some reason. See
README.md
for more information.Tips for reviewer
Reviewing commit-by-commit may work best.