Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the canary environment mzcompose workflow to run against the Materialize Production Sandbox #21799

Merged

Conversation

philip-stoev
Copy link
Contributor

Motivation

Our canary environments that were used to determine if a release is good enough to go were largely empty/idle and were therefore not a good canary for anything.

With this mzcompose workflow, one can create a complete set of sources/generators/materialized views and then validate that they are running properly and have not stalled for some reason. See README.md for more information.

Tips for reviewer

Reviewing commit-by-commit may work best.

When an error is encountered, testdrive prints the entire line
where the error happened. Certain lines can contain
passwords which should not be printed as this will
cause them to end up in the Buildkite log and artifacts.
@philip-stoev philip-stoev requested a review from a team as a code owner September 18, 2023 12:35
@philip-stoev philip-stoev requested review from def- and nrainer-materialize and removed request for a team September 18, 2023 12:36
@philip-stoev philip-stoev changed the title Allow the canary environment mzcompose workflow to run against the shared sandbox Allow the canary environment mzcompose workflow to run against the Materialize Production Sandbox Sep 18, 2023
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, some minor suggestions for the README

test/canary-environment/README.md Outdated Show resolved Hide resolved
test/canary-environment/README.md Show resolved Hide resolved
test/canary-environment/mzcompose.py Show resolved Hide resolved
Adjust mzcompose so that it connects to the production cloud.

All required connection information is passed as environment variables.
@philip-stoev philip-stoev merged commit 6b1ae80 into MaterializeInc:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants