Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/user: lower case json parser output #21798

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

joacoc
Copy link
Contributor

@joacoc joacoc commented Sep 18, 2023

Motivation

This PR lowercases the output from the parser.

Before:

CREATE MATERIALIZED VIEW my_view AS SELECT 
    json_column->>'anonymousId' AS anonymousId,
    json_column->'context'->>'userAgent' AS context_userAgent,
    json_column->'context'->>'Mixpanel' AS context_Mixpanel,
    ...

Now:

CREATE MATERIALIZED VIEW my_view AS SELECT 
    json_column->>'anonymousId' AS anonymousid,
    json_column->'context'->>'userAgent' AS context_useragent,
    json_column->'context'->>'Mixpanel' AS context_mixpanel,
    ...

@joacoc joacoc requested review from ParkMyCar and a team September 18, 2023 11:53
@joacoc joacoc requested a review from a team as a code owner September 18, 2023 11:53
@joacoc joacoc enabled auto-merge (squash) September 18, 2023 11:54
@joacoc
Copy link
Contributor Author

joacoc commented Sep 18, 2023

Additional: Should we also turn camelCase/kebab-case to snake_case?

@joacoc joacoc merged commit adfbfb7 into MaterializeInc:main Sep 18, 2023
@joacoc joacoc deleted the lower-case-json branch September 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants