catalog: Move builtin to catalog crate #21791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
catalog-builtins
branch
from
4a88879
to
57600f1
Compare
jkosh44
changed the title
This commit moves the mz_adapter::catalog::builtin module to mz_catalog::builtin which cleans up some duplicate structs.
jkosh44
force-pushed
the
catalog-builtins
branch
from
57600f1
to
b5478fd
Compare
|
This PR has higher risk. Make sure to carefully review the file hotspots. In addition to having this change reviewed, adequate tests should be considered and it may be useful to add observability and/or a feature flag. What's This?
Buggy File Hotspots:
|
moulimukherjee
pushed a commit
to benesch/materialize
that referenced
this pull request
Sep 19, 2023
* main: (24 commits) catalog: Remove stash details from transactions (MaterializeInc#21784) catalog: Move builtin to catalog crate (MaterializeInc#21791) sqlsmith/sqlancer: Fix mzcompose permissions storage: merge `Controller` with `StorageControllerState` canary environment: Add README.md canary environment: Target the production cloud transform: add `ColumnNames` attribute transform: pass context to attribute constructors transform: struct-based `DerivedAttributes` container transform: add `explain` directive to `test_transforms` transform: add column names support in `DefSource` spec blocks LICENSE: update change date doc: add inherited tables to PG source known limitations persist: split out a maelstrom-persist-base mzimage Make output of lint-docs-catalog CI-friendly adapter: Apply write ts in bootstrapping (MaterializeInc#21802) adapter: add more LaunchDarkly contexts Correct CREATE CLUSTER example syntax (MaterializeInc#21800) rbac: allow `EXPLAIN` commands in `user_privilege_hack` mzcompose: Allow the dbt service to accept environment variables ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the mz_adapter::catalog::builtin module to mz_catalog::builtin which cleans up some duplicate structs.
Motivation
This PR refactors existing code.
Tips for Reviewer
A lot of tests were moved from builtin.rs to catalog.rs resulting in a large diff.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.