Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloudtest] Allow setting additional headers in cloudtest requests #21779

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Sep 15, 2023

Motivation

Allows passing in headers for requests made via cloudtest 'controllers'. Necessary for setting new X-MZ-Api-Version header planned to be introduced in PR for https://github.com/MaterializeInc/cloud/issues/7429

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

Copy link
Contributor

@nrainer-materialize nrainer-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@rjobanp rjobanp merged commit 556dcce into main Sep 18, 2023
129 checks passed
@rjobanp rjobanp deleted the roshan/request-headers branch September 18, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants