rbac: allow EXPLAIN commands in user_privilege_hack
#21778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
approved these changes
Sep 16, 2023
| // * SHOW CREATE ... commands. See | ||
| // <https://github.com/MaterializeInc/materialize/issues/18027> for | ||
| // more details. | ||
| // * EXPLAIN PLAN ... EXPLAIN TIMESTAMP and commands. See |
There was a problem hiding this comment.
Suggested change
| // * EXPLAIN PLAN ... EXPLAIN TIMESTAMP and commands. See | |
| // * EXPLAIN PLAN ... and EXPLAIN TIMESTAMP ... commands. See |
aalexandrov
force-pushed
the
issue_20478
branch
from
ee0866d
to
5c87395
Compare
aalexandrov
force-pushed
the
issue_20478
branch
from
5c87395
to
a2b39c5
Compare
aalexandrov
commented
Sep 18, 2023
|
|
||
| $ postgres-connect name=mz_support url=postgres://mz_support:materialize@${testdrive.materialize-internal-sql-addr} | ||
|
|
||
| > CREATE SOURCE auction_house FROM LOAD GENERATOR AUCTION FOR ALL TABLES WITH (size = '1'); |
There was a problem hiding this comment.
@MaterializeInc/testing I just realized that having WITH (size = '1') here might break CI (although it didn't break the CI tests for this PR). Feel free to remove this suffix.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #21760
Motivation
Turns out that one bit was missing from #21760 in order to resolve MaterializeInc/database-issues#6160.
This does in fact resolve MaterializeInc/database-issues#6160.
Tips for reviewer
I had to change the definition of
user_privilege_hacka bit.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.