Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redacted_sql column to mz_prepared_statement_history #21758

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Add redacted_sql column to mz_prepared_statement_history #21758

merged 2 commits into from
Sep 15, 2023

Conversation

umanwizard
Copy link
Contributor

Motivation

  • This PR adds a known-desirable feature.

    redacted SQL in statement logging

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@umanwizard umanwizard requested a review from a team September 14, 2023 16:48
@umanwizard umanwizard requested a review from a team as a code owner September 14, 2023 16:48
@umanwizard umanwizard requested review from a team and ParkMyCar September 14, 2023 16:48
@umanwizard umanwizard enabled auto-merge (squash) September 15, 2023 14:42
@umanwizard umanwizard merged commit 13a7bbc into MaterializeInc:main Sep 15, 2023
@benesch
Copy link
Member

benesch commented Sep 15, 2023

Thanks, @umanwizard! Linking up the related issue: MaterializeInc/database-issues#5916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkMyCar ParkMyCar ParkMyCar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umanwizard @benesch @ParkMyCar