Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persist] Don't assume old parts are totally consolidated #21733

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Sep 13, 2023

Motivation

Support for #21615.

In particular, this is necessary if we want to assume that the output of the Consolidator is indeed consolidated.

Tips for reviewer

To my knowledge the last important bug was fixed in df46c74, and 0.67.0 is the first release that includes it.

I think this means it's safe to assert on ordering in the consolidator now, but I'll run all the upgrade tests to make sure.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@bkirwi bkirwi requested a review from a team as a code owner September 13, 2023 15:30
src/persist-client/src/iter.rs Outdated Show resolved Hide resolved
src/persist-client/src/iter.rs Outdated Show resolved Hide resolved
src/persist-client/src/internal/paths.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@danhhz danhhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

would love to see the de-dent happen. deduping WriterKey parsing logic i'll leave to your judgement

@bkirwi
Copy link
Contributor Author

bkirwi commented Sep 14, 2023

Landed both - thanks for the review!

@bkirwi bkirwi merged commit 0d416e6 into MaterializeInc:main Sep 14, 2023
@bkirwi bkirwi deleted the consolidation-version branch September 14, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants