[cloudtest] Use correct union types for sql execute statements #21423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This swaps the
LiteralString
type annotation to theQuery
type union defined bypsycopg
so I can use the psycopgsql.SQL
type in a DDL statement where I can't use aLiteralString
. See https://www.psycopg.org/psycopg3/docs/advanced/typing.html#checking-literal-strings-in-queries for detailsI also switched the
Sequence[Any]
annotations to use thepsycopg
Params
union-type to future-proof that.sql_query
andsql_execute
still annotate theirquery
parameter asstr
, which is actually incorrect with the move topsycopg
3.. I can update those too but I was wondering if there was a reason to leave them as-is. LMK your thoughts.Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.