Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog: Add more columns to pg_roles #14282

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Aug 17, 2022

This commit adds some of the missing columns from Postgres catalog
view pg_roles. Also adds a migration test for the new columns.

Motivation

Adds Postgres compatibility and migration tests.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.

  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-protobuf label.

  • This PR includes the following user-facing behavior changes:

    • Adds the following columns to pg_roles:
      • rolname,
      • rolsuper,
      • rolinherit,
      • rolcreaterole,
      • rolcreatedb,
      • rolcanlogin,
      • rolreplication,
      • rolconnlimit,
      • rolvaliduntil,
      • rolbypassrls

This commit adds some of the missing columns from Postgres catalog
view pg_roles. Also adds a migration test for the new columns.
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkosh44 jkosh44 merged commit 7c745d5 into MaterializeInc:main Aug 18, 2022
@jkosh44 jkosh44 deleted the pg-role branch August 18, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants