Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interval binary encoding test #10590

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Feb 10, 2022

Closes #4926.

Adds test for Interval binary encoding

Motivation

This PR fixes a recognized bug: #4926. I was unable to re-create the bug, so I added a passing test with the scenario that the bug describes.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR adds a release note for any user-facing behavior changes.

@jkosh44
Copy link
Contributor Author

jkosh44 commented Feb 10, 2022

Seems like CI didn't run any tests, anyone know how to force the tests to be run?

@jkosh44 jkosh44 merged commit b769f4a into MaterializeInc:main Feb 10, 2022
@jkosh44 jkosh44 deleted the interval-binary-panic branch February 10, 2022 17:45
wangandi pushed a commit to wangandi/materialize that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgrepr: binary interval encoding can panic
2 participants