Skip to content

Fixing ElementName bindings in TransitioningContent#951

Merged
Keboo merged 1 commit into
MaterialDesignInXAML:masterfrom
Keboo:fix950
Jul 25, 2018
Merged

Fixing ElementName bindings in TransitioningContent#951
Keboo merged 1 commit into
MaterialDesignInXAML:masterfrom
Keboo:fix950

Conversation

@Keboo

@Keboo Keboo commented May 8, 2018

Copy link
Copy Markdown
Member

Fixing name scope issue that would cause ElementName bindings to fail when used inside of a TransitioningContentBase.

Fixes #950

@SandaruwanFdo

Copy link
Copy Markdown

Is this fixed? I'am new to GitHub

@Keboo

Keboo commented May 11, 2018

Copy link
Copy Markdown
Member Author

@proxact this is a pull request. So it is the first step into getting it fixed. The general flow looks like this:

  1. Issue created in github.
  2. Fix created in a pull request (this is the step we are currently at).
  3. Pull request is reviewed and merged into the repository (this requires @ButchersBoy to do it)
  4. NuGet package created with the latest code that contains the fix.

If you want to compile the library manually you can always check out my branch and build it manually.

@Keboo Keboo changed the title Fixing ElementName binding sin TransitioningContent Fixing ElementName bindings in TransitioningContent May 15, 2018
@Keboo Keboo added this to the 2.4.1 milestone Jul 19, 2018
@Keboo
Keboo merged commit bfc61c7 into MaterialDesignInXAML:master Jul 25, 2018
@Keboo
Keboo deleted the fix950 branch July 25, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants