Skip to content

Pull Request: Adding New Control NumericUpDown Control to Material Design XAML Toolkit - #3175

Merged
Keboo merged 11 commits into
MaterialDesignInXAML:masterfrom
Asivaprasadam:feature/NumericUpDown
Jun 13, 2024
Merged

Pull Request: Adding New Control NumericUpDown Control to Material Design XAML Toolkit#3175
Keboo merged 11 commits into
MaterialDesignInXAML:masterfrom
Asivaprasadam:feature/NumericUpDown

Conversation

@Asivaprasadam

@Asivaprasadam Asivaprasadam commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Pull Request: Adding NumericUpDown control to Material Design

Preface

Hello everyone,

This is my first contribution to a GitHub project, and I am excited to be a part of the MaterialDesignXamlToolkit community. I have been working on this NumericUpDown control for Material Design, and I believe it will be a valuable addition to the project.

I must admit that my lack of experience contributing to open-source projects has delayed me in committing to this code. However, I have decided that I don't want to delay it any further by waiting to complete all the planned improvements before submitting my contribution when there is a strong community that can help me out with my 1st contribution.

Since this is my first GitHub contribution, I would appreciate any feedback and advice you can provide. I am eager to learn from more experienced developers and improve my skills, so please do not hesitate to give me constructive criticism and suggestions for improvements. I am committed to contributing to this project and look forward to continuing to learn and improve.

Thank you for taking the time to review my contribution, and I look forward to your feedback.

Description

This pull request adds a new NumericUpDown control to the Material Design project. The control provides a user-friendly way to input numeric values and is designed to fit seamlessly into the Material Design UI.

Changes Made

  • Created a new NumericUpDown control that allows users to input numeric values within a specific range.
  • Implemented the first base style for the control, nothing fancy and definitely needs improvement.
  • Integrated the NumericUpDown with the Material Design MainDemo and added a page to display styles.

Pending Potential Changes

  • Provided additional documentation to help users understand the control's functionality and usage.
  • Improve the support for common input methods, such as keyboard and mouse input.
  • Create logarithmic click/ scroll support to enhance the UX/ user experience.
  • Tune the base style to adhere more closely to Material Design principles.
  • Create additional styling templates following Material Design guidelines to provide more options for users
  • Add all the new styles to the Main Demo App NumericUpDown control page to showcase the control.

Screenshots

image

Related Issues

  1. Issue Outlined NumericUpDown not displayed correctly when disabled #2592
  2. Issue NumericUpDown: Outline has a line at the bottom #2557
  3. Issue NumericUpDown Outlined #2448

Additional Notes

None

@Asivaprasadam
Asivaprasadam marked this pull request as ready for review April 25, 2023 20:24
@Asivaprasadam
Asivaprasadam marked this pull request as draft April 25, 2023 20:28
@Keboo
Keboo self-requested a review April 25, 2023 21:36

@Keboo Keboo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing that would be good to do is write some UI tests for this control. If you need any help setting that up, let me know.

Comment thread MaterialDesignThemes.Wpf/NumericUpDown.cs Outdated
Comment thread MaterialDesignThemes.Wpf/NumericUpDown.cs Outdated
<smtx:XamlDisplay Margin="10,5"
VerticalAlignment="Top"
UniqueKey="numericUpDown_default">
<materialDesign:NumericUpDown />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to put in a few more examples showing the commands, Min and Max, and any other styles.

Comment thread MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml Outdated
Comment thread MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml Outdated
@Keboo Keboo added this to the 4.9.0 milestone Apr 27, 2023
@ElieTaillard

Copy link
Copy Markdown
Collaborator

Plus and Minus seem inverted according to your screenshot. Here are some examples of what we usually see in UI:
image
image

@Keboo Keboo modified the milestones: 4.9.0, 5.0.0 May 11, 2023
@tim-gromeyer

Copy link
Copy Markdown

Any update on this? @Asivaprasadam? Would be cool to have this in my project, this is exactly what I need!

@arjun-sivaprasadam

arjun-sivaprasadam commented Jan 10, 2024

Copy link
Copy Markdown

@tim-gromeyer I have changed my work abit and switched from UI development to more of a backend development. But I'll check with the progress and do an update possibly asap, but lets say optimally by end of Jan worst case by march. Feel free to take over too!

@Keboo Keboo modified the milestones: 5.0.0, 5.1.0 Jan 25, 2024
@Keboo
Keboo force-pushed the feature/NumericUpDown branch from 799b4e4 to dfe8f13 Compare April 18, 2024 06:06
@Keboo
Keboo marked this pull request as ready for review April 18, 2024 06:06
@Keboo
Keboo requested a review from nicolaihenriksen April 18, 2024 06:06

@nicolaihenriksen nicolaihenriksen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments to consider.

Comment thread MaterialDesignThemes.UITests/TestBase.cs Outdated
Comment thread MaterialDesignThemes.Wpf/NumericUpDown.cs Outdated
Comment thread MaterialDesignThemes.Wpf/NumericUpDown.cs Outdated
Comment thread MaterialDesignThemes.Wpf/NumericUpDown.cs
Comment thread MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml Outdated
@Keboo Keboo added enhancement release notes Items are likely to be highlighted in the release notes. labels Apr 21, 2024
Arjun Sivaprasadam and others added 10 commits June 12, 2024 22:27
@Keboo
Keboo force-pushed the feature/NumericUpDown branch from defe04b to ee5f24f Compare June 13, 2024 08:00
@Keboo
Keboo enabled auto-merge (squash) June 13, 2024 08:01
@Keboo
Keboo merged commit 9a82d57 into MaterialDesignInXAML:master Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement release notes Items are likely to be highlighted in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants