DatePicker ContextMenu fix - Partial revert of #2502 - #3018
Merged
Conversation
The PR included a seemingly non-related change from DynamicResource to StaticResource which effectively broke the ability to override the style. Only reverting this particular part of the PR: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/pull/2502/files#diff-9223925c6d6052ba159059666e83a002034f38005382dd8684c025dbba4f985bL460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3007
As we discussed, I am rolling back a small part of a previous PR to fix the issue.
The PR #2502 included a seemingly non-related change from DynamicResource to StaticResource which effectively broke the ability to override the style. Only reverting this particular part of the PR:
https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/pull/2502/files#diff-9223925c6d6052ba159059666e83a002034f38005382dd8684c025dbba4f985bL460