-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leading spacing on property and function declaration expansion #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 96.43% 96.52% +0.08%
==========================================
Files 16 16
Lines 646 662 +16
==========================================
+ Hits 623 639 +16
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Hello @dafurman, thank you once again for your valuable contribution! I'm currently refactoring the factories in our project to enhance the capabilities of |
Yeah absolutely! No rush on this at all! I don't mind handling the git conflicts and reworking this if necessary after your refactor. |
I've modified several files and simplified the implementation of some nodes, which has resulted in a few conflicts in this PR. Will you find time to resolve them? If not, I can attempt to address them in my free time. |
Sure! I can probably get to that later today or this weekend! |
0eb8596
to
999e2f8
Compare
@Matejkob The PR should be good to go for review now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great improvement! I was quite annoyed about these leading spaces... Great work! Thanks for doin' it! 🫶
Context
Indentation and spacing was a little off in some Macro expansion, so I wanted to make it more readable.
Given the example protocol:
This is the expansion in
main
:And this is the expansion in this PR:
Testing

Existing tests pass, and the adjusted tests pass.