With errors #189
Merged
With errors #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly-handle-errors
…operly-handle-errors Signed-off-by: Nick Revin <n@nrvn.cc>
Signed-off-by: Nick Revin <n@nrvn.cc>
The previous commits changed both the Go API and the response from several template functions. This change restores the Go API and the template functions. The new error handling functionality is in a new set of template functions one can opt-in to using
technosophos
approved these changes
Sep 27, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of #132. It restores the Go API to the existing comparability and moves the error handling template functions into ones with their own names. The existing template functions are restored. This allows both cases to be satisfied.
Note, the commits from #132 have been pulled in here.