Skip to content

Proper handling read_data and read_search.search_data #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proper handling read_data and read_search.search_data #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions restapi/api_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func NewAPIObject(iClient *APIClient, opts *apiObjectOpts) (*APIObject, error) {
id: opts.id,
idAttribute: opts.idAttribute,
data: make(map[string]interface{}),
readData: make(map[string]interface{}),
readData: nil,
updateData: make(map[string]interface{}),
destroyData: make(map[string]interface{}),
apiData: make(map[string]interface{}),
Expand Down Expand Up @@ -339,25 +339,6 @@ func (obj *APIObject) readObject() error {
getPath = fmt.Sprintf("%s?%s", obj.getPath, obj.queryString)
}

send := ""
if len(obj.readData) > 0 {
readData, _ := json.Marshal(obj.readData)
send = string(readData)
if obj.debug {
log.Printf("api_object.go: Using read data '%s'", send)
}
}

resultString, err := obj.apiClient.sendRequest(obj.readMethod, strings.Replace(getPath, "{id}", obj.id, -1), send)
if err != nil {
if strings.Contains(err.Error(), "unexpected response code '404'") {
log.Printf("api_object.go: 404 error while refreshing state for '%s' at path '%s'. Removing from state.", obj.id, obj.getPath)
obj.id = ""
return nil
}
return err
}

searchKey := obj.readSearch["search_key"]
searchValue := obj.readSearch["search_value"]

Expand All @@ -374,8 +355,7 @@ func (obj *APIObject) readObject() error {
}
searchData := ""
if len(obj.readSearch["search_data"]) > 0 {
tmpData, _ := json.Marshal(obj.readSearch["search_data"])
searchData = string(tmpData)
searchData = obj.readSearch["search_data"]
if obj.debug {
log.Printf("api_object.go: Using search data '%s'", searchData)
}
Expand All @@ -392,6 +372,25 @@ func (obj *APIObject) readObject() error {
return obj.updateState(string(objFoundString))
}

send := ""
if obj.readData != nil {
readData, _ := json.Marshal(obj.readData)
send = string(readData)
if obj.debug {
log.Printf("api_object.go: Using read data '%s'", send)
}
}

resultString, err := obj.apiClient.sendRequest(obj.readMethod, strings.Replace(getPath, "{id}", obj.id, -1), send)
if err != nil {
if strings.Contains(err.Error(), "unexpected response code '404'") {
log.Printf("api_object.go: 404 error while refreshing state for '%s' at path '%s'. Removing from state.", obj.id, obj.getPath)
obj.id = ""
return nil
}
return err
}

return obj.updateState(resultString)
}

Expand Down