Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Fix failing github actions #7

Merged
merged 4 commits into from
May 10, 2023

Conversation

joseph-neeraj
Copy link

PR checklist

  • An issue/feature request has been created for this PR
  • Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • File the PR against the master branch
  • The code in this PR is covered by unit tests

Link to issue/feature request: add the link here

Description

Github actions are failing because of macos-xcode version mismatch. This PR pins the versions of the runner and xcode so this doesn't happen again.

joseph-neeraj and others added 4 commits May 5, 2023 14:29
The build was failing in github actions due to mismatch between macos and xcode versions.
This commit pins the macos and xcode versions so that this doesn't happen again
Copy link

@danny-gallagher danny-gallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danny-gallagher danny-gallagher added the safe The PR has been reviewed by Mastercard and has been validated to be safe label May 10, 2023
@joseph-neeraj joseph-neeraj merged commit a042e68 into Mastercard:main May 10, 2023
@joseph-neeraj joseph-neeraj deleted the fix/github-actions branch May 10, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
safe The PR has been reviewed by Mastercard and has been validated to be safe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants