Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/553-require-rp-id-auth-options #555

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

MasterKale
Copy link
Owner

This PR makes the rpID argument a required one when calling generateAuthenticationOptions().

Fixes #553.

Breaking changes

Before:

  generateRegistrationOptions({ rpID: 'example.com', ... });
generateAuthenticationOptions();

After:

  generateRegistrationOptions({ rpID: 'example.com', ... });
generateAuthenticationOptions({ rpID: 'example.com' });

@MasterKale MasterKale added the package:server @simplewebauthn/server label Apr 12, 2024
@MasterKale MasterKale merged commit 69335ae into master Apr 12, 2024
1 check passed
@MasterKale MasterKale deleted the fix/553-require-rp-id-auth-options branch April 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rpID required when generating authentication options
1 participant