Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/536-default-displayname-to-empty-string #538

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix/536-default-displayname-to-empty-string #538

merged 1 commit into from
Mar 7, 2024

Conversation

MasterKale
Copy link
Owner

This PR changes the behavior of generateRegistrationOptions(). userDisplayName will no longer default to userName but to an empty string ("") instead when not specified.

Fixes #536.

@MasterKale MasterKale added this to the v10.0.0 milestone Mar 7, 2024
@MasterKale MasterKale added the package:server @simplewebauthn/server label Mar 7, 2024
@MasterKale MasterKale merged commit fe90e27 into master Mar 7, 2024
1 check passed
@MasterKale MasterKale removed this from the v10.0.0 milestone Apr 12, 2024
@MasterKale MasterKale deleted the fix/536-default-displayname-to-empty-string branch April 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:server @simplewebauthn/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default userDisplayName to empty string when not specified
1 participant
@MasterKale