Fix edge compute issues with cbor-x dynamic functions #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding webauthn support to a Next.js app, I kept getting the following error during build:
Turns out
cbor-x
declares some dynamic functions that are not compatible with Vercel's edge compute and Cloudflare workers (info).Thankfully, fixing it is fairly straighforward.
cbor-x
exports a version of itself without these eval statements viacbor-x/index-no-eval
I tested the change locally by changing the cbor import line in my node_modules to be
export * as cborx from 'cbor-x/index-no-eval';
and it fixed the issue.
The Deno import can continue pointing to the regular export since it supports eval.
PS: a few months ago I merge a PR here for something related - lack of support for streaming APIs in serverless environments. That has since changed, so importing from
cbor-x/index
instead ofcbor-x/encode
isn't an issue anymore.