Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/503-consistent-utf8-challenge-strings #507

Merged
merged 3 commits into from
Jan 20, 2024
Merged

fix/503-consistent-utf8-challenge-strings #507

merged 3 commits into from
Jan 20, 2024

Conversation

MasterKale
Copy link
Owner

This PR updates generateRegistrationOptions() to treat string arguments for challenge as UTF-8 strings. This makes the behavior consistent with generateAuthenticationOptions().

Fixed #503.

@MasterKale MasterKale added the package:server @simplewebauthn/server label Jan 20, 2024
@MasterKale MasterKale added this to the v8.3.7 milestone Jan 20, 2024
@MasterKale MasterKale merged commit dd387e6 into master Jan 20, 2024
2 checks passed
@MasterKale MasterKale deleted the fix/503-consistent-utf8-challenge-strings branch January 20, 2024 06:34
@jsaady jsaady mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:server @simplewebauthn/server
Projects
None yet
Milestone
v8.3.7
Development

Successfully merging this pull request may close these issues.

Treat all custom string challenges as UTF-8 strings
1 participant
@MasterKale